ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 42572: Ambari server throws error when unused configs are present in blueprint
Date Thu, 21 Jan 2016 14:02:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42572/#review115625
-----------------------------------------------------------

Ship it!


Looks fine to me.  Just a minor issue below.  

Thanks for creating this patch!


ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
(line 85)
<https://reviews.apache.org/r/42572/#comment176611>

    This looks fine to me.
    
    Just one minor issue/request:
    
    Could you maybe add a log statement here, to indicate that the unnecessary configuration
is being removed?  
    
    The logging might be useful for users over time, to let them know that the unnecessary
config types can be removed. 
    
    In addition, there are cases where services rely on other services' configuration, so
if we ever ran into a situation where removing the config was a problem, the logging would
simplify debugging. 
    
    Thanks.


- Robert Nettleton


On Jan. 20, 2016, 9:33 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42572/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 9:33 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, Sumit Mohanty,
and Sebastian Toader.
> 
> 
> Bugs: AMBARI-14745
>     https://issues.apache.org/jira/browse/AMBARI-14745
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case of a blueprint contains unused config types -> updaters can apply on the unused
properties. In same cases this can cause exceptions. E.g.: single host updater on a property
-> no host found for a service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
c719009 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java 108ff74

>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
8afff46 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationTest.java
e971e03 
> 
> Diff: https://reviews.apache.org/r/42572/diff/
> 
> 
> Testing
> -------
> 
> Unit testing is in progress.
> FT: blueprints with unused config types.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message