ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 42553: Add params to alert definitions during ambari upgrade
Date Wed, 20 Jan 2016 14:53:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42553/#review115429
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 20, 2016, 4:51 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42553/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 4:51 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Jonathan Hurley, and Sumit
Mohanty.
> 
> 
> Bugs: AMBARI-14740
>     https://issues.apache.org/jira/browse/AMBARI-14740
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We have many parameters for different alert dfeinitions. But these parameters will be
available only when you are deploying new cluster. If you are upgrading to the last version
of ambari, these params will be not available, because they were not added during ambari upgrade.
We have no code in UpgradeCatalogs which should add all these params.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
82aa6ca 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42553/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message