ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aravindan Vijayan" <avija...@hortonworks.com>
Subject Re: Review Request 42357: Unnecessary multiple TreeMap creation
Date Wed, 20 Jan 2016 13:33:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42357/#review115415
-----------------------------------------------------------

Ship it!


Ship It!

- Aravindan Vijayan


On Jan. 15, 2016, 5:44 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42357/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:44 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14694
>     https://issues.apache.org/jira/browse/AMBARI-14694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In TimelineReadHelper
>     TreeMap<Long, Double> sortedByTimeMetrics = new TreeMap(
>       PhoenixHBaseAccessor.readMetricFromJSON(rs.getString("METRICS")));
> but readMetricFromJSON returns the TreeMap
> it can lead to memory wasting
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
c5d7b0c 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java
dc27614 
> 
> Diff: https://reviews.apache.org/r/42357/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] ambari-metrics .................................... SUCCESS [2.638s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [5.221s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [5.875s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.969s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [4.551s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [11.473s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [2:40.199s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [5.288s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [2:29.464s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] --------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message