ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Toader" <stoa...@hortonworks.com>
Subject Re: Review Request 42501: Blueprints: Stack advisor should consider user provided inputs on ''ONLY_STACK_DEFAULTS_APPLY" strategy
Date Tue, 19 Jan 2016 15:40:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42501/#review115171
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 182)
<https://reviews.apache.org/r/42501/#comment176063>

    Add comment what this method does.



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 183)
<https://reviews.apache.org/r/42501/#comment176062>

    Why do we need this to be a ConcurentMap ?



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 195)
<https://reviews.apache.org/r/42501/#comment176064>

    Maybe it's better to name it defaultValue or configPropDefaultValue.



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 200)
<https://reviews.apache.org/r/42501/#comment176065>

    This "else" seems wrong. It adds the same configProp value as the "if" branch above.



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 211)
<https://reviews.apache.org/r/42501/#comment176067>

    Add comment to the method header.



ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
(line 214)
<https://reviews.apache.org/r/42501/#comment176066>

    Use rather "==" as that's null safe.


- Sebastian Toader


On Jan. 19, 2016, 4:06 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42501/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 4:06 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty,
and Sebastian Toader.
> 
> 
> Bugs: AMBARI-14722
>     https://issues.apache.org/jira/browse/AMBARI-14722
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If the config_recommendation_strategy is 'ONLY_STACK_DEFAULTS_APPLY' in the cluster creation
template, it should apply configurations only on stack defaults. 
> In case of a user overrides a stack default property, stack advisor output should not
be considered, and force to use the user provided property.
> (ALWAYS_APPLY strategy still won't use user provided properties in the output of stack
advisor, only as inputs)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
337ad06 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java
60a8dde 
> 
> Diff: https://reviews.apache.org/r/42501/diff/
> 
> 
> Testing
> -------
> 
> FT: provision with multiple blueprints (with user provided properties in the cluster-creation
tempalte and in the blueprint too)
> Unit testing is in progress...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message