ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Nagar" <gna...@hortonworks.com>
Subject Re: Review Request 42453: Hive view should return 400 (instead of 500) when the hive query cannot be compiled
Date Tue, 19 Jan 2016 09:35:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42453/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 9:35 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Srimanth Gunturi, Sid Wagle,
and Yusaku Sako.


Changes
-------

If error message conatins "Error while compiling statement:" then throw HiveInvalidQuery Exception.


Bugs: AMBARI-14707
    https://issues.apache.org/jira/browse/AMBARI-14707


Repository: ambari


Description
-------

Added HiveInvalidQueryException class. 
HiveInvalidQueryException is thrown if the error code is between 10000-19999. 
In ServiceFormattedException setting 400 response code if HiveInvalidQueryException is thrown.


Diffs (updated)
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveInvalidQueryException.java
PRE-CREATION 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Utils.java 5b42b1f 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/ServiceFormattedException.java
eaea2ff 
  contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/UtilsTest.java de66bef


Diff: https://reviews.apache.org/r/42453/diff/


Testing
-------

Manual testing Done.

mvn clean install

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.407 sec
Running org.apache.ambari.view.hive.client.ConnectionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.32 sec
Running org.apache.ambari.view.hive.client.UtilsTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.109 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.577 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.204 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.166 sec
Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.878 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.905 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.07 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.622 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.142 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.102 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.631 sec
Running org.apache.ambari.view.hive.resources.upload.DataParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.101 sec

Results :

Tests run: 62, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.016s
[INFO] Finished at: Mon Jan 18 16:53:40 IST 2016
[INFO] Final Memory: 53M/779M
[INFO] ------------------------------------------------------------------------


Thanks,

Gaurav Nagar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message