ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 42337: AMBARI-14678. RU - Oozie HA, Service Check fails since the pre-upgrade directive has multiple tasks that should run only on the specified hosts
Date Tue, 19 Jan 2016 03:17:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42337/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 3:17 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Jayush Luniya,
and Nate Cole.


Changes
-------

Addressed all comments.


Bugs: AMBARI-14678
    https://issues.apache.org/jira/browse/AMBARI-14678


Repository: ambari


Description
-------

STR:
HDP 2.2
Multiple Oozie Servers
RU to HDP 2.3

The pre-upgrade directive for Oozie has 
```
<pre-upgrade>
  <task xsi:type="execute" hosts="all" summary="Shut down all Oozie servers">
    <script>scripts/oozie_server.py</script>
    <function>stop</function>
  </task>

  <task xsi:type="execute" hosts="any" summary="Upgrading the database and creating a new
sharelib">
    <script>scripts/oozie_server_upgrade.py</script>
    <function>upgrade_oozie_database_and_sharelib</function>
  </task>
</pre-upgrade>
```

Notice that the first task runs on all hosts, and the second task runs on exactly one random
host. The problem is that the scheduler runs both tasks in one stage on the union of these
hosts. Therefore, the 2nd task runs on the wrong set of hosts.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java aa852bd

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java
b0df83f 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java 980f88e

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java
69b3f8b 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java
057c310 
  ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 2cf9da9

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml cbd9c2a

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 816fe13

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml 5166c4b

  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 8b2f2a3 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 375da12 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml ea3d6a6 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 34423f9

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 50c8584

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 876342c 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml f145de1 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml a9ee860

  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml b8bd1ee 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e61942

  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/OOZIE/metainfo.xml PRE-CREATION

  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_bucket_test.xml 0e6d914

  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
8f78d0f 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml 4f71b4a 

Diff: https://reviews.apache.org/r/42337/diff/


Testing (updated)
-------

Verified during RU/EU from HDP 2.2 to 2.3 with multiple Oozie Servers.
Unit tests passed.


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message