ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard Zang" <rz...@hortonworks.com>
Subject Re: Review Request 42377: Combo Search: Implement on-demand value list on top of visualsearch.js
Date Mon, 18 Jan 2016 21:13:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42377/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 9:13 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-14700
    https://issues.apache.org/jira/browse/AMBARI-14700


Repository: ambari


Description (updated)
-------

Refactor usage of visualsearch.js. Relocate loading related code to controller. Add an exapmle
flow for on demand value loading when creating filter.


Diffs
-----

  ambari-web/app/controllers.js 5f3f841 
  ambari-web/app/controllers/main/host/combo_search_box.js PRE-CREATION 
  ambari-web/app/routes/main.js 70714b9 
  ambari-web/app/templates/main/host.hbs 1c575a9 
  ambari-web/app/views/main/host/combo_search_box.js 927a540 

Diff: https://reviews.apache.org/r/42377/diff/


Testing
-------

Manually tested on live cluster, All unit tests passed.
  23097 tests complete (17 seconds)
  165 tests pending


Thanks,

Richard Zang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message