ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 42369: Kerberos automation logic should use stack advisor when determining configuration updates
Date Mon, 18 Jan 2016 17:53:10 GMT


> On Jan. 18, 2016, 11:21 a.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java,
line 120
> > <https://reviews.apache.org/r/42369/diff/1/?file=1198998#file1198998line120>
> >
> >     BlueprintConfigurationsProcessor.setMissingProperties sets this property in
cluster-env as well. May be we can move this out to ClusterConfigurationRequest.configureKerberos()
?
> 
> Robert Levas wrote:
>     While testing, this value was not set when needed while accessing the Stack Advisor.
It is necessary for cluster-env/security-enabled to be set to "true" if we are to enable Kerberos
so that the Stack Advisor behaves as we Kerberos was enabled - though it is not yet enabled
according to the exsting configs.
> 
> Oliver Szabo wrote:
>     now, stack advisor called after configureKerberos(), maybe that's better place for
setting any values which related to kerberos. if after then the stack advisor unset security-enabled
property, then the problem with stack advisor logic (python part)

Currently security_enabled is being set in org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor#setMissingConfigurations.
The stack advisor is not changing the value, its just the order of operations does not lend
itself to setting the value when needed. 

On this note, there was a ready we waited to set security_enabled... but that reason may have
gone away now.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------


On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 6:25 a.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-14698
>     https://issues.apache.org/jira/browse/AMBARI-14698
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Kerberos automation logic should use the stack advisor when determining configuration
updates. This will ensure that property updates are valid given the cluster's configuration
and whether the cluster was created using the API, UI, or BluePrints.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
337ad06 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
b6686b4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
6f0fa27 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
4c241d1 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
359e651 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java
8ab04ff 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java
84248dc 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java
fba3eea 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
1e89272 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java
d5531a6 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
8861549 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
d1886b9 
> 
> Diff: https://reviews.apache.org/r/42369/diff/
> 
> 
> Testing
> -------
> 
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
> 
> # Local test results: 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
> 
> # Jenkins test results: 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message