ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 42365: AMBARI-14697 : AMS monitor should use same hostname as ambari agent and server.
Date Fri, 15 Jan 2016 22:37:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42365/#review114784
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Jan. 15, 2016, 10:32 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42365/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 10:32 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14697
>     https://issues.apache.org/jira/browse/AMBARI-14697
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS monitor should use the same hostname as supplied to the agent by the server. This
patch does away with the use of the custom hostname_script provided by the agent in the monitor
code.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 2403a14

>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
a3780ff 
>   ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/host_info.py 60e9294

>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
fef60b7 
> 
> Diff: https://reviews.apache.org/r/42365/diff/
> 
> 
> Testing
> -------
> 
> Ambari-server and ambari-metrics-host-monitoring python unit tests pass.
> 
> Manual testing done.
> 
> Submitted patch through apache.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message