ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 41191: AMBARI-14317: Hive service check with Beeline should not pass in ssl settings if SSL is disabled
Date Thu, 14 Jan 2016 18:47:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41191/#review114537
-----------------------------------------------------------



ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py (line
39)
<https://reviews.apache.org/r/41191/#comment175388>

    What is calling this with incorrect values?
    
    ssl is expected to come in as a boolean. so why compare against a string, only to then
assign it a boolean again?


- Alejandro Fernandez


On Jan. 5, 2016, 2:33 p.m., Bing Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41191/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:33 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-14317
>     https://issues.apache.org/jira/browse/AMBARI-14317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Services -> Hive -> Configs,
> 1. disable SSL
> 2. add the properties for ssl keystore in hive-site.xml
> hive.server2.keystore.path
> hive.server2.keystore.password
> 3. save the configuration, and restart hive services
> Then I can get an alert from HiveServer2, go to the details I found that
> the beeline tried to connect HS2 with "ssl=true;sslTrustStore=/path/trust_store.jks;trustStorePassword=xyz",
which is NOT correct.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py
55fd6bd 
> 
> Diff: https://reviews.apache.org/r/41191/diff/
> 
> 
> Testing
> -------
> 
> I have verified it in my local cluster.
> 
> 
> Thanks,
> 
> Bing Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message