ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 42175: Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY
Date Tue, 12 Jan 2016 20:16:56 GMT


> On Jan. 12, 2016, 8:05 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py,
line 191
> > <https://reviews.apache.org/r/42175/diff/1/?file=1192885#file1192885line191>
> >
> >     Is this change related to the Blueprint changes in this patch?
> 
> bhuvnesh chaudhary wrote:
>     Thanks Robert for the review.
>     
>     This change is not directly related to Blueprint. However, during testing Hawq Master
start failed which boiled down to 2 reasons, and 1st was was one liner so included as a combined
fix.
>     1 - We perform HAWQ related setup only from HAWQMASTER component, but those are even
required for HAWQSTANDBY component. Since both of them can be masters, so we should remove
the check to identify active master and do the common steps.
>     2 - Configuration were not getting updated to respective component hostnames during
blueprint deploy.
>     If you suggest that i create another jira for that point 1. above let me know.

Thanks for the clarification.  There's no need to remove this from your patch, since the change
is relatively simple, and is related to Blueprint deployments of these components anyway.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42175/#review114057
-----------------------------------------------------------


On Jan. 12, 2016, 7:57 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42175/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya,
Oleksandr Diachenko, Robert Nettleton, Richard Zang, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14621
>     https://issues.apache.org/jira/browse/AMBARI-14621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Blueprint deploy should update the value localhost for HAWQMASTER, HAWQSTANDBY with the
name of their respective component hostname. It should also update the value of hawq_dfs_url
to NAMENODE HOST.
> The logic to replace the hostname is currently only on the Web UI due to which during
deploy, hawq_master_address_host, hawq_standby_address_host and hawq_dfs_url are set to localhost
and hawq start fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
261798c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
95c4eba 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
21710e5 
> 
> Diff: https://reviews.apache.org/r/42175/diff/
> 
> 
> Testing
> -------
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message