ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 42175: Blueprint deploy should update the value localhost for HAWQMASTER and HAWQSTANDBY
Date Tue, 12 Jan 2016 20:05:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42175/#review114057
-----------------------------------------------------------

Ship it!


Apart from a few minor issues I've listed below, the patch looks fine to me. 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
(line 2152)
<https://reviews.apache.org/r/42175/#comment174852>

    Minor issue:
    
    I would recommend adding the new PropertyUpdater registrations to the "singleHostTopologyUpdaters"
map, rather than the multi-host map.  
    
    Either should work fine, but it probably makes more sense to keep the single-host properties
in the single-host map, for tracking and maintenance purposes.



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py

<https://reviews.apache.org/r/42175/#comment174851>

    Is this change related to the Blueprint changes in this patch?


- Robert Nettleton


On Jan. 12, 2016, 7:57 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42175/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya,
Oleksandr Diachenko, Robert Nettleton, Richard Zang, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14621
>     https://issues.apache.org/jira/browse/AMBARI-14621
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Blueprint deploy should update the value localhost for HAWQMASTER, HAWQSTANDBY with the
name of their respective component hostname. It should also update the value of hawq_dfs_url
to NAMENODE HOST.
> The logic to replace the hostname is currently only on the Web UI due to which during
deploy, hawq_master_address_host, hawq_standby_address_host and hawq_dfs_url are set to localhost
and hawq start fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
261798c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py
95c4eba 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
21710e5 
> 
> Diff: https://reviews.apache.org/r/42175/diff/
> 
> 
> Testing
> -------
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message