ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Toader" <stoa...@hortonworks.com>
Subject Re: Review Request 42026: Rest API returns incorrect cluster creation request status using Blueprints until nodes join the cluster
Date Sun, 10 Jan 2016 08:21:32 GMT


> On Jan. 9, 2016, 11:22 p.m., Sumit Mohanty wrote:
> > https://issues.apache.org/jira/browse/AMBARI-14551 has an unit test failure
> 
> Sebastian Toader wrote:
>     I don't think this unit test failure is caused by this patch:
>     
>     UpgradeCatalog221Test.testExecuteDMLUpdates:156 ยป NullPointer
>     
>     I saw this failing earlier with other patch: https://issues.apache.org/jira/browse/AMBARI-14586
>     
>     What is strange that it doesn't fail on my local machine even though I synced trunk
a couple of hours ago.
> 
> Sumit Mohanty wrote:
>     OK. Lets monitor the test separately.
> 
> Sumit Mohanty wrote:
>     Can you attach a patch for branch-2.2

It's attached to the apache jira AMBARI-14551


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42026/#review113628
-----------------------------------------------------------


On Jan. 9, 2016, 10:24 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42026/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14551
>     https://issues.apache.org/jira/browse/AMBARI-14551
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. If the cluster is provisioned using Blueprint and if there are no tasks created verify
the status of the topology logical request (that will exist only for Blueprints) to determine
if the request was prior completed or it's waiting for hosts to register and be assigned to
host groups. 
> 2. Upon host deletion delete the topology host requests associated with the deleted host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
f0d9fde 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
1a71afa 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
ca09ab8 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java ad7c8fd

>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
80d19d2 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
03ef06d 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
178adc5 
> 
> Diff: https://reviews.apache.org/r/42026/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on the 3 node cluster created using Blueprint (before agents registered
with ambari server)
> 
> Unit tests:
> Results :
> 
> Tests run: 3741, Failures: 0, Errors: 0, Skipped: 29
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message