ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastian Toader" <stoa...@hortonworks.com>
Subject Re: Review Request 42026: Rest API returns incorrect cluster creation request status using Blueprints until nodes join the cluster
Date Sat, 09 Jan 2016 18:13:12 GMT


> On Jan. 9, 2016, 7:05 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
line 880
> > <https://reviews.apache.org/r/42026/diff/2/?file=1189502#file1189502line880>
> >
> >     Should we modify the table, perhaps in later releases, to use host id. I think
its one of the few tables that use host name instead of host if to refer to hosts? If you
agree, lets have a JIRA open for that change.

Are you referring to "topology_host_request" table?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42026/#review113617
-----------------------------------------------------------


On Jan. 9, 2016, 7:02 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42026/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 7:02 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14551
>     https://issues.apache.org/jira/browse/AMBARI-14551
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. If the cluster is provisioned using Blueprint and if there are no tasks created verify
the status of the topology logical request (that will exist only for Blueprints) to determine
if the request was prior completed or it's waiting for hosts to register and be assigned to
host groups. 
> 2. Upon host deletion delete the topology host requests associated with the deleted host.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
f0d9fde 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java ad7c8fd

>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
03ef06d 
> 
> Diff: https://reviews.apache.org/r/42026/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on the 3 node cluster created using Blueprint (before agents registered
with ambari server)
> 
> Unit tests:
> Results :
> 
> Tests run: 3741, Failures: 0, Errors: 0, Skipped: 29
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message