ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Hill" <greg.h...@rackspace.com>
Subject Review Request 42032: [AMBARI-12916] Make server hostname configurable
Date Thu, 07 Jan 2016 20:23:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42032/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-12916
    https://issues.apache.org/jira/browse/AMBARI-12916


Repository: ambari


Description
-------

This lets you configure the hostname that the Ambari server passes to the views and agent
so you can specify it differently from the system hostname.  This is useful in cases where
you want to use a fqdn for API access but a local hostname for local cluster communication.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 371d5d2

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a7f206a 

Diff: https://reviews.apache.org/r/42032/diff/


Testing
-------

Honestly, not much.  There weren't any existing unit tests for the code I modified and I'm
not a Java developer so I didn't really know where to start with creating them.  It's a pretty
simple change and doesn't break any existing tests, but I'm happy to do some more testing
if someone can provide some direction.


Thanks,

Greg Hill


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message