ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pallav Kulshreshtha" <pallav....@gmail.com>
Subject Re: Review Request 41970: Hive View Visual explain caches and doesn't account for settings changes
Date Wed, 06 Jan 2016 07:59:32 GMT


> On Jan. 6, 2016, 7:43 a.m., DIPAYAN BHOWMICK wrote:
> > contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js, line
426
> > <https://reviews.apache.org/r/41970/diff/1/?file=1183935#file1183935line426>
> >
> >     Not required to set this to self.

Made the required changes and uploaded the latest patch.


- Pallav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41970/#review113025
-----------------------------------------------------------


On Jan. 6, 2016, 7:58 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41970/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 7:58 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-14559
>     https://issues.apache.org/jira/browse/AMBARI-14559
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Removed the piece of code which says change the explain graph only when json is changed.
since explain graph may change if the settings property like "hive.auto.convert.join" gets
changed. So now with this implementation graph will be refreshed every time user clicks on
'visual explain' tab.
> - No new unit test case needed.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js
509fe85 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/visual-explain.hbs
119d95d 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js 76cc35f

> 
> Diff: https://reviews.apache.org/r/41970/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> Here are the build logs:
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.456 sec
> Running org.apache.ambari.view.hive.client.ConnectionTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.426 sec
> Running org.apache.ambari.view.hive.client.UtilsTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.147 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.477 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.298 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.3 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.245 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.096 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.834 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.202 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.594 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.798 sec
> Running org.apache.ambari.view.hive.resources.upload.DataParserTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.138 sec
> 
> Results :
> 
> Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 340 resources included (use -debug for more details)
> Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit'
is not recognized.
> Compiler warnings:
>   WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD'
is not recognized.'
> Warning:  org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing'
is not recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD'
is not recognized.
> Warning:  org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit'
is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 339
licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0-SNAPSHOT.jar
to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0-SNAPSHOT/hive-1.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/pom.xml
to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0-SNAPSHOT/hive-1.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:02.175s
> [INFO] Finished at: Wed Jan 06 13:01:37 IST 2016
> [INFO] Final Memory: 61M/1092M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message