Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D083510ECA for ; Mon, 28 Dec 2015 14:09:49 +0000 (UTC) Received: (qmail 68150 invoked by uid 500); 28 Dec 2015 14:09:49 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 68111 invoked by uid 500); 28 Dec 2015 14:09:49 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 68093 invoked by uid 99); 28 Dec 2015 14:09:49 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Dec 2015 14:09:49 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8AF572C14F6 for ; Mon, 28 Dec 2015 14:09:49 +0000 (UTC) Date: Mon, 28 Dec 2015 14:09:49 +0000 (UTC) From: "Hudson (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AMBARI-14501) Improve config recommendations flow 2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072741#comment-15072741 ] Hudson commented on AMBARI-14501: --------------------------------- SUCCESS: Integrated in Ambari-trunk-Commit #4097 (See [https://builds.apache.org/job/Ambari-trunk-Commit/4097/]) AMBARI-14501 Improve config recommendations flow 2. (ababiichuk) (ababiichuk: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=73a850eb0bb781d3f6650b176d375aca9b5021f2]) * ambari-web/app/utils/config.js * ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs * ambari-web/app/routes/add_service_routes.js * ambari-web/app/controllers/wizard/step7_controller.js * ambari-web/app/views/common/controls_view.js * ambari-web/app/mixins/common/configs/configs_saver.js * ambari-web/app/controllers/main/service/info/configs.js * ambari-web/app/models/configs/objects/service_config_property.js * ambari-web/app/mixins.js * ambari-web/test/mixins/common/configs/enhanced_configs_test.js * ambari-web/app/mixins/common/serverValidator.js * ambari-web/app/mixins/common/configs/config_recommendations.js * ambari-web/app/mixins/common/configs/config_recommendation_parser.js * ambari-web/app/mixins/common/configs/enhanced_configs.js * ambari-web/app/views/common/modal_popups/select_groups_popup.js * ambari-web/test/views/common/configs/widgets/config_widget_view_test.js * ambari-web/test/controllers/main/service/info/config_test.js * ambari-web/app/mixins/common/configs/config_with_override_recommendation_parser.js * ambari-web/app/models/configs/objects/service_config.js > Improve config recommendations flow 2 > ------------------------------------- > > Key: AMBARI-14501 > URL: https://issues.apache.org/jira/browse/AMBARI-14501 > Project: Ambari > Issue Type: Bug > Components: ambari-web > Affects Versions: 2.4.0 > Reporter: Andrii Babiichuk > Assignee: Andrii Babiichuk > Fix For: 2.4.0 > > Attachments: AMBARI-14501.patch > > > Simplify logic to make it reusable (ex. for Kerberos) and performance improvement. > Separete logic for original configs and overrides, move it do diff mixins > Separate logic for recommendatins popup manipulations. > Move specific logic like override initial value or ignore recommendations (ex Add service installed services) to appropriate controllers. > Besides logical refactor this cahges decrease recommendation flow process for 0.2-0.4 secs for full stack -- This message was sent by Atlassian JIRA (v6.3.4#6332)