Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2025D18DFD for ; Tue, 29 Dec 2015 22:02:08 +0000 (UTC) Received: (qmail 54444 invoked by uid 500); 29 Dec 2015 22:02:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 54408 invoked by uid 500); 29 Dec 2015 22:02:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 54391 invoked by uid 99); 29 Dec 2015 22:02:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Dec 2015 22:02:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CDFDF296F0E; Tue, 29 Dec 2015 22:02:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0933321269935080847==" MIME-Version: 1.0 Subject: Re: Review Request 40742: Ambari Views : each view should have separate log file for better troubleshooting From: "Alejandro Fernandez" To: "DIPAYAN BHOWMICK" , "Rohit Choudhary" , "Jaimin Jetly" Cc: "Nitiraj Rathore" , "Ambari" , "Alejandro Fernandez" Date: Tue, 29 Dec 2015 22:02:06 -0000 Message-ID: <20151229220206.4182.62575@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40742/ X-Sender: "Alejandro Fernandez" References: <20151126121558.24387.39934@reviews.apache.org> In-Reply-To: <20151126121558.24387.39934@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============0933321269935080847== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40742/#review112229 ----------------------------------------------------------- Ship it! Ship It! - Alejandro Fernandez On Nov. 26, 2015, 12:15 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40742/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 12:15 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, and Rohit Choudhary. > > > Bugs: AMBARI-14084 > https://issues.apache.org/jira/browse/AMBARI-14084 > > > Repository: ambari > > > Description > ------- > > Earlier : > Logs of all the views goes into the same file where ambari logs also go i.e. in ambari-server.log file > > After Patch : > There will be separate log files for each views. > > In the patch : > changes in log4j.properties. > Created separate appenders for each view. > Loggers for each view with separate package name. > set additivity of loggers to false so that logs are not duplicated into ambari-server.log > > > Diffs > ----- > > ambari-server/conf/unix/log4j.properties c87b1f4 > ambari-server/conf/windows/log4j.properties 8a69508 > > Diff: https://reviews.apache.org/r/40742/diff/ > > > Testing > ------- > > Manual testing done to look if each view is generating logs in their own log file. > > > Thanks, > > Nitiraj Rathore > > --===============0933321269935080847==--