Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7273506110901351325=="
MIME-Version: 1.0
Subject: Re: Review Request 41526: Hive Metastore alert timeout
From: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Fri, 18 Dec 2015 16:37:33 -0000
Message-ID: <20151218163733.11596.13644@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vitalyi Brodetskyi" <noreply@reviews.apache.org>
References: <20151218162853.1672.26274@reviews.apache.org>
In-Reply-To: <20151218162853.1672.26274@reviews.apache.org>
Reply-To: "Vitalyi Brodetskyi" <vbrodetskyi@hortonworks.com>

--===============7273506110901351325==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On Гру. 18, 2015, 4:28 після полудня, Andrew Onischuk wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java, line 145
> > <https://reviews.apache.org/r/41526/diff/2/?file=1170920#file1170920line145>
> >
> >     This is pretty useful function to parse alerts source json and change some values.
> >     Could we move those to general functions into abstractCatalog.
> >     
> >     I think we will need that a lot in future.
> >     
> >     Let's say we can create 2 functions one returns json as map, other saves the json. Or anything else general you think is better.
> 
> Andrew Onischuk wrote:
>     The goal is to make future upgrade changes to alerts source look as small as possible.

We have some usefull functions in entity as of now, so i think it will be better to add some additional there. Even if we will decide to add some functions in AbstractUpgradeCatalog, i think it should be implemented as a feature in separate jira, with Unit Tests and etc.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41526/#review111196
-----------------------------------------------------------


On Гру. 18, 2015, 4:23 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41526/
> -----------------------------------------------------------
> 
> (Updated Гру. 18, 2015, 4:23 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Jonathan Hurley, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14424
>     https://issues.apache.org/jira/browse/AMBARI-14424
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For Hive metastore and server alerts
> 1) Change default timeout to 60 seconds
> 2) Make this a configurable script param, so people can pass this in
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py 55fd6bd 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5e22f71 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 55e3f78 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py c7a9102 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py a04c2a6 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41526/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


--===============7273506110901351325==--