Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B57A518C94 for ; Tue, 15 Dec 2015 18:43:30 +0000 (UTC) Received: (qmail 39058 invoked by uid 500); 15 Dec 2015 18:43:30 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 39018 invoked by uid 500); 15 Dec 2015 18:43:30 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 38991 invoked by uid 99); 15 Dec 2015 18:43:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Dec 2015 18:43:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C12F92AE5DB; Tue, 15 Dec 2015 18:43:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8521701254377740508==" MIME-Version: 1.0 Subject: Re: Review Request 41397: AMBARI-14383 Add support for Ranger TagSync process as a component under RANGER From: "Alejandro Fernandez" To: "Mahadev Konar" , "Sumit Mohanty" , "Selvamohan Neethiraj" , "Madhan Neethiraj" , "Alejandro Fernandez" , "Jaimin Jetly" , "Nate Cole" , "Velmurugan Periasamy" Cc: "Ambari" , "Gautam Borad" Date: Tue, 15 Dec 2015 18:43:27 -0000 Message-ID: <20151215184327.19750.42962@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41397/ X-Sender: "Alejandro Fernandez" References: <20151215164701.19749.31931@reviews.apache.org> In-Reply-To: <20151215164701.19749.31931@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============8521701254377740508== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41397/#review110527 ----------------------------------------------------------- ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 88) just check len(...) > 0 ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py (line 72) Is this already supported by hdp-select? ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 397) version is the value during an RU/EU. When not in an upgrade, should use /usr/hdp/current/.../ - Alejandro Fernandez On Dec. 15, 2015, 4:46 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41397/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 4:46 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Madhan Neethiraj, Mahadev Konar, Nate Cole, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: AMBARI-14383 > https://issues.apache.org/jira/browse/AMBARI-14383 > > > Repository: ambari > > > Description > ------- > > Ranger TagSync is a separate component that will be responsible for synchronizing the tags from Apache Atlas into Apache Ranger (db). > > Add Ranger TagSync component under existing RANGER service. > The component will be a master component > Ability to start/stop the component independently of Ranger Admin. > Ability to install the component on any host of the cluster > Support should be available only from HDP 2.3 > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py fd83c53 > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5628f33 > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py b6e5ee9 > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_service.py 4f711c3 > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py PRE-CREATION > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 8de0d80 > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-tagsync-site.xml PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml cf3afbe > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml cce20be > > Diff: https://reviews.apache.org/r/41397/diff/ > > > Testing > ------- > > Installed Ranger on centos 6 and enabled Ranger TagSync module. > > Tested minor upgrade from 2.3.x to 2.3.xx > > > Thanks, > > Gautam Borad > > --===============8521701254377740508==--