Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C213C18A59 for ; Mon, 14 Dec 2015 22:16:04 +0000 (UTC) Received: (qmail 30000 invoked by uid 500); 14 Dec 2015 22:16:04 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 29958 invoked by uid 500); 14 Dec 2015 22:16:04 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 6095 invoked by uid 99); 14 Dec 2015 22:09:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 22:09:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5DB2B294301; Mon, 14 Dec 2015 22:09:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4147812319043496246==" MIME-Version: 1.0 Subject: Re: Review Request 41220: In stack service scripts "commandParams/version" is misused From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Sumit Mohanty" , "Sebastian Toader" Cc: "Ambari" , "Oliver Szabo" Date: Mon, 14 Dec 2015 22:09:24 -0000 Message-ID: <20151214220924.19749.74171@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41220/ X-Sender: "Alejandro Fernandez" References: <20151214215909.19750.79887@reviews.apache.org> In-Reply-To: <20151214215909.19750.79887@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============4147812319043496246== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 14, 2015, 9:59 p.m., Alejandro Fernandez wrote: > > Pushed to trunk, > > commit e9c9f18cc0c0112f83b95d6edffbb657a33a72e5 > > > > Pushed to branch-2.2, > > commit fce013b54d94fb55a8953518332a099d4d1c01f3 Just reverted from branch-2.2, please remove that branch from the code review "branch" field - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41220/#review110316 ----------------------------------------------------------- On Dec. 12, 2015, 6:33 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41220/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 6:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-14330 > https://issues.apache.org/jira/browse/AMBARI-14330 > > > Repository: ambari > > > Description > ------- > > In this patch: https://reviews.apache.org/r/41133/ > Although the issue was fixed, "commandParams/version" should not be redefined, because it used by RU/EU. Instead of using that parameter I checking that thriftserver is available. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py a4e31bf > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py c4bbdc1 > > Diff: https://reviews.apache.org/r/41220/diff/ > > > Testing > ------- > > Python tests succeeded for ambari-server. > Other Unit tests are in progress. > > FT: EU ugrade/downgrade: > HDP 2.2 -> 2.3.0 no thriftserver > HDP 2.2 -> 2.3.2 no thriftserver > HDP 2.3.0 -> 2.3.2 no thriftserver > HDP 2.3.2 -> 2.3.4 have thriftserver (this one is in progress) > > > Thanks, > > Oliver Szabo > > --===============4147812319043496246==--