Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6976592283223969306=="
MIME-Version: 1.0
Subject: Re: Review Request 41217: RESTART STORM/NIMBUS fails during EU,
 2.1 --> 2.3
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jayush Luniya" <jluniya@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>
Date: Thu, 10 Dec 2015 19:09:15 -0000
Message-ID: <20151210190915.1619.2885@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20151210183746.1619.53793@reviews.apache.org>
In-Reply-To: <20151210183746.1619.53793@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============6976592283223969306==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 10, 2015, 8:37 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 98
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line98>
> >
> >     Isnt storm_lib_dir = /usr/lib/storm/lib/ already on HDP 2.1?

No, during EU it is  /usr/hdp/current/storm-nimbus/lib


> On Dec. 10, 2015, 8:37 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py, line 101
> > <https://reviews.apache.org/r/41217/diff/1/?file=1158956#file1158956line101>
> >
> >     format not required here

good catch


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41217/#review109823
-----------------------------------------------------------


On Dec. 10, 2015, 9:08 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41217/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 9:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-14326
>     https://issues.apache.org/jira/browse/AMBARI-14326
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 149, in <module>
> Nimbus().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 514, in restart
> self.start(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 68, in start
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py", line 50, in configure
> storm("nimbus")
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 89, in thunk
> return fn(*args, **kwargs)
> File "/var/lib/ambari-agent/cache/common-services/STORM/0.9.1.2.1/package/scripts/storm.py", line 103, in storm
> only_if=format("ls {metric_collector_sink_jar}")
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 154, in __init__
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 158, in run
> self.run_action(resource, action)
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 121, in run_action
> provider_action()
> File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 238, in action_run
> tries=self.resource.tries, try_sleep=self.resource.try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
> result = function(command, **kwargs)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
> tries=tries, try_sleep=try_sleep)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
> result = _call(command, **kwargs_copy)
> File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'ambari-sudo.sh ln -s /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar /usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' returned 1. ln: target `/usr/hdp/current/storm-nimbus/lib/ambari-metrics-storm-sink.jar' is not a directory
> {code}
> 
> Perhaps because there are two files that satisfy the wildcard:
> {code}
> ls /usr/lib/storm/lib/ambari-metrics-storm-sink*.jar
> /usr/lib/storm/lib/ambari-metrics-storm-sink.jar  /usr/lib/storm/lib/ambari-metrics-storm-sink-with-common-2.2.0.0.1262.jar
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py 4e97c65 
> 
> Diff: https://reviews.apache.org/r/41217/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Checked upgrade on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============6976592283223969306==--