Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC38F18E2F for ; Wed, 9 Dec 2015 21:33:22 +0000 (UTC) Received: (qmail 79589 invoked by uid 500); 9 Dec 2015 21:33:22 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 79555 invoked by uid 500); 9 Dec 2015 21:33:22 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 79540 invoked by uid 99); 9 Dec 2015 21:33:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Dec 2015 21:33:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 35A4D292A4B; Wed, 9 Dec 2015 21:33:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1156252638532402940==" MIME-Version: 1.0 Subject: Review Request 41150: Storm configuration wrong From: "Sebastian Toader" To: "Sumit Mohanty" , "Robert Nettleton" , "Oliver Szabo" Cc: "Ambari" , "Sebastian Toader" Date: Wed, 09 Dec 2015 21:33:21 -0000 Message-ID: <20151209213321.1618.84018@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sebastian Toader" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41150/ X-Sender: "Sebastian Toader" Reply-To: "Sebastian Toader" X-ReviewRequest-Repository: ambari --===============1156252638532402940== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41150/ ----------------------------------------------------------- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. Bugs: AMBARI-14302 https://issues.apache.org/jira/browse/AMBARI-14302 Repository: ambari Description ------- BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort. In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf Diff: https://reviews.apache.org/r/41150/diff/ Testing ------- Unit tests in progress.... Manual testing in progress... Thanks, Sebastian Toader --===============1156252638532402940==--