Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============0517002241497188751=="
MIME-Version: 1.0
Subject: Re: Review Request 41132: Ranger admin HA installation with
 Blueprints fail due to error in stack advisor
From: "Andrew Onischuk" <aonishuk@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Oliver Szabo" <oszabo@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Sebastian Toader" <stoader@hortonworks.com>
Date: Wed, 09 Dec 2015 10:48:12 -0000
Message-ID: <20151209104812.1619.84632@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Andrew Onischuk" <noreply@reviews.apache.org>
References: <20151209104115.1619.6161@reviews.apache.org>
In-Reply-To: <20151209104115.1619.6161@reviews.apache.org>
Reply-To: "Andrew Onischuk" <aonishuk@hortonworks.com>

--===============0517002241497188751==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41132/#review109495
-----------------------------------------------------------

Ship it!


Once you run the python tests you got my 'Ship it' :)

- Andrew Onischuk


On Dec. 9, 2015, 10:41 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41132/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 10:41 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Oliver Szabo.
> 
> 
> Bugs: AMBARI-14287
>     https://issues.apache.org/jira/browse/AMBARI-14287
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger admin HA installation fails when the cluster is deployed with a Blueprint that has stack advisor enabled with:
> 'unicode' object has no attribute 'isempty'
> 
> Removed the isempty() function call as there is no such function on python string. It's enough just to call strip() on the string and verify that is not empty.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b 
> 
> Diff: https://reviews.apache.org/r/41132/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster of 3 nodes using Blueprint having Ranger Admin in HA mode and cluster creation template with stack advisor enabled ("config_recommendation_strategy" : "ALWAYS_APPLY").
> 
> Verified that ranger admin installed correctly and also the plugins registered with ranger.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


--===============0517002241497188751==--