Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 938D518FEA for ; Tue, 8 Dec 2015 23:14:27 +0000 (UTC) Received: (qmail 44414 invoked by uid 500); 8 Dec 2015 23:14:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 44365 invoked by uid 500); 8 Dec 2015 23:14:17 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 44350 invoked by uid 99); 8 Dec 2015 23:14:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2015 23:14:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 79FBD292536; Tue, 8 Dec 2015 23:14:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5786684746935285232==" MIME-Version: 1.0 Subject: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present From: "Aravindan Vijayan" To: "Sid Wagle" , "Sumit Mohanty" , "Dmytro Sen" Cc: "Aravindan Vijayan" , "Ambari" Date: Tue, 08 Dec 2015 23:14:17 -0000 Message-ID: <20151208231417.1618.54417@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aravindan Vijayan" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41109/ X-Sender: "Aravindan Vijayan" Reply-To: "Aravindan Vijayan" X-ReviewRequest-Repository: ambari --===============5786684746935285232== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41109/ ----------------------------------------------------------- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-14278 https://issues.apache.org/jira/browse/AMBARI-14278 Repository: ambari Description ------- The Storm Metrics reporter property (metrics.reporter.register) is a known config item that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version with AMS. If that is not done, there is a stack advisor exception that is caused. FIX Added a check for the presence of the property. If the property is present, we add it to validation items. Else, we dont add to validation item Diffs ----- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py f3e6f8b Diff: https://reviews.apache.org/r/41109/diff/ Testing ------- ambari-server python unit tests pass. Manually tested. Thanks, Aravindan Vijayan --===============5786684746935285232==--