Return-Path: 
 <dev-return-97557-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A1EF218710
	for <apmail-ambari-dev-archive@www.apache.org>;
 Thu,  3 Dec 2015 18:47:17 +0000 (UTC)
Received: (qmail 3851 invoked by uid 500); 3 Dec 2015 18:47:17 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 3819 invoked by uid 500); 3 Dec 2015 18:47:17 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 3799 invoked by uid 99); 3 Dec 2015 18:47:16 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 18:47:16 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 4CAB4292217;
	Thu,  3 Dec 2015 18:47:16 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5930641150511348724=="
MIME-Version: 1.0
Subject: Re: Review Request 40925: Create KerberosHelper method to return the
 set of configuration updates required for Kerberization
From: "Robert Levas" <rlevas@hortonworks.com>
To: "Sandor Magyari" <smagyari@hortonworks.com>,
 "Robert Nettleton" <rnettleton@hortonworks.com>
Cc: "Robert Levas" <rlevas@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 03 Dec 2015 18:47:16 -0000
Message-ID: <20151203184716.1718.27839@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Robert Levas" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/40925/
X-Sender: "Robert Levas" <noreply@reviews.apache.org>
References: <20151203184617.7624.18557@reviews.apache.org>
In-Reply-To: <20151203184617.7624.18557@reviews.apache.org>
Reply-To: "Robert Levas" <rlevas@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============5930641150511348724==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40925/
-----------------------------------------------------------

(Updated Dec. 3, 2015, 1:47 p.m.)


Review request for Ambari, Robert Nettleton and Sandor Magyari.


Changes
-------

This is the correct patch.


Bugs: AMBARI-14186
    https://issues.apache.org/jira/browse/AMBARI-14186


Repository: ambari


Description
-------

Create a KerberosHelper  method to return the set of configuration updates required for Kerberization.

```
public Map<String, Map<String, String>>getServiceConfiguationUpdates(Cluster cluster, Map<String, Map<String, String>> configurations, Set<String> services)
```


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 482756f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 3a050f4 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 7a4f3e9 

Diff: https://reviews.apache.org/r/40925/diff/


Testing
-------

Manually tested

# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:00:56.301s
[INFO] Finished at: Thu Dec 03 13:23:07 EST 2015
[INFO] Final Memory: 70M/1571M
[INFO] ------------------------------------------------------------------------

# Jenkins test results: PENDING


Thanks,

Robert Levas


--===============5930641150511348724==--