Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============0679181818341963384=="
MIME-Version: 1.0
Subject: Re: Review Request 40686: HAWQ gives ownership of hawq parent
 directory to hawq_user
From: "jun aoki" <jun.aoki.dev@gmail.com>
To: "bhuvnesh chaudhary" <bchaudhary@pivotal.io>, "Matt" <mithmatt@gmail.com>,
 "jun aoki" <jun.aoki.dev@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 02 Dec 2015 21:13:12 -0000
Message-ID: <20151202211312.1718.85262@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "jun aoki" <noreply@reviews.apache.org>
References: <20151202054827.7624.66867@reviews.apache.org>
In-Reply-To: <20151202054827.7624.66867@reviews.apache.org>
Reply-To: "jun aoki" <jun.aoki.dev@gmail.com>

--===============0679181818341963384==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 2, 2015, 5:48 a.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py, line 87
> > <https://reviews.apache.org/r/40686/diff/1/?file=1139420#file1139420line87>
> >
> >     I'm probably missing something here and educate me.
> >     If the chown execution at the parent directory  is deleted completely, how chmod actually occurs at the actual directory (segment_dir in this particular case) which has the right permission?
> 
> bhuvnesh chaudhary wrote:
>     chmod is executed by root to make the segment or master dir non readable to users other than gpadmin. 
>     these directories when created are given gpadmin as the ownership. so now they hve gpadmin as the owner and 700 as the permission.
>     parent directories of segment / master dir were earlier given gpadmin ownership as init db logs were created under the parent directory which is now fixed at hawq and thus step is removed.

Matt, bhuvnesh, thank you for clarification!


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40686/#review108608
-----------------------------------------------------------


On Nov. 25, 2015, 1:08 a.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40686/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 1:08 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-14054
>     https://issues.apache.org/jira/browse/AMBARI-14054
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ service gives the ownership of parent directories of hawq_master_dir and hawq_segment_dir to hawq_user.
> 
> This is not ideal because the parent directory might be / (root directory), and root directory ownership should not be given to hawq_user
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 0e349d2 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/master_helper.py fdfd7c9 
> 
> Diff: https://reviews.apache.org/r/40686/diff/
> 
> 
> Testing
> -------
> 
> Manually tested 
> 
> After changes were made, HAWQ was deployed on a cluster, and the directory ownership and permissions were verified for hawq_master_dir and hawq_segment_dir
> 
> 
> Thanks,
> 
> Matt
> 
>


--===============0679181818341963384==--