Return-Path: 
 <dev-return-97296-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 67F5D1892E
	for <apmail-ambari-dev-archive@www.apache.org>;
 Wed,  2 Dec 2015 14:35:23 +0000 (UTC)
Received: (qmail 81829 invoked by uid 500); 2 Dec 2015 14:35:23 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 81795 invoked by uid 500); 2 Dec 2015 14:35:23 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 81777 invoked by uid 99); 2 Dec 2015 14:35:23 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 14:35:23 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id AABBA1CF8A5;
	Wed,  2 Dec 2015 14:35:22 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============3921513586563856482=="
MIME-Version: 1.0
Subject: Re: Review Request 40852: AMBARI-14147. RU: Kafka broker restart
 failed on downgrade from HDP 2.3 to 2.2
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Swapan Shridhar" <sshridhar@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Dmytro Grinenko" <hapy.lestat@gmail.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>
Date: Wed, 02 Dec 2015 14:35:22 -0000
Message-ID: <20151202143522.1718.38255@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/40852/
X-Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20151202031151.7624.89895@reviews.apache.org>
In-Reply-To: <20151202031151.7624.89895@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============3921513586563856482==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40852/#review108644
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Dec. 1, 2015, 10:11 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40852/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 10:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-14147
>     https://issues.apache.org/jira/browse/AMBARI-14147
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDP Version: 2.2.8.0-3150
> Kafka service
> Rolling Upgrade to 2.3.4.0-3335, then downgrade
> 
> Kafka broker restart failed on downgrade. (Upgrade had no issues)
> 
> ```
> Traceback (most recent call last):
>   File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 101, in <module>
>     KafkaBroker().execute()
>   File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 217, in execute
>     method(env)
>   File \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\", line 506, in restart
>     self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
>   File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 67, in pre_upgrade_restart
>     self.configure(env)
>   File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py\", line 44, in configure
>     kafka()
>   File \"/var/lib/ambari-agent/cache/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py\", line 53, in kafka
>     listeners = kafka_server_config['listeners'].replace(\"localhost\", params.hostname)
> KeyError: 'listeners'",
> ```
> 
> 
> This happened because the code in kafka.py is comparing against params.hdp_stack_version (which stays as HDP 2.3 during a downgrade) instead of params.version (which is the version either upgrading or downgrading to).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py 2bd93d2 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka_broker.py 3caeb6d 
>   ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml f4c7f61 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml b48184e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 766f443 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 0c18f32 
> 
> Diff: https://reviews.apache.org/r/40852/diff/
> 
> 
> Testing
> -------
> 
> EU and RU from HDP 2.2 to 2.3 followed by downgrade.
> Python unit tests passed,
> 
> ----------------------------------------------------------------------
> Total run:839
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


--===============3921513586563856482==--