Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1925E188CB for ; Wed, 2 Dec 2015 00:17:09 +0000 (UTC) Received: (qmail 19967 invoked by uid 500); 2 Dec 2015 00:17:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 19944 invoked by uid 500); 2 Dec 2015 00:17:08 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 18955 invoked by uid 99); 2 Dec 2015 00:17:08 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 00:17:08 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4BE31291802; Wed, 2 Dec 2015 00:17:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5051691904314944053==" MIME-Version: 1.0 Subject: Re: Review Request 40810: AMBARI-14121. Express Upgrade authors configs as _anonymous instead of auth user From: "Alejandro Fernandez" To: "Swapan Shridhar" , "Nate Cole" , "Dmitro Lisnichenko" , "Dmytro Grinenko" , "Jonathan Hurley" Cc: "Ambari" , "Alejandro Fernandez" Date: Wed, 02 Dec 2015 00:17:08 -0000 Message-ID: <20151202001708.7624.52351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40810/ X-Sender: "Alejandro Fernandez" References: <20151201225346.1718.35115@reviews.apache.org> In-Reply-To: <20151201225346.1718.35115@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============5051691904314944053== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40810/ ----------------------------------------------------------- (Updated Dec. 2, 2015, 12:17 a.m.) Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar. Bugs: AMBARI-14121 https://issues.apache.org/jira/browse/AMBARI-14121 Repository: ambari Description ------- When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as "_anonymous" instead of the authenticate user. This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations but doesn't pass it the username. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 748dbbe ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java 44b13de ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3bf6cad ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 93360bd ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 38370c7 ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml 6a2986e ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml PRE-CREATION Diff: https://reviews.apache.org/r/40810/diff/ Testing ------- Waiting for unit test results. Ran manually for UpgradeResourceProviderTest.java and it passed. Verified during an Express Upgrade from HDP 2.2 to 2.3 ``` ambari=> select service_name, version, user_name from serviceconfig; service_name | version | user_name --------------+---------+----------- HDFS | 1 | admin ZOOKEEPER | 1 | admin MAPREDUCE2 | 1 | admin YARN | 1 | admin ZOOKEEPER | 2 | admin MAPREDUCE2 | 2 | admin HDFS | 2 | admin YARN | 2 | admin ``` Thanks, Alejandro Fernandez --===============5051691904314944053==--