Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE18018626 for ; Tue, 1 Dec 2015 15:59:27 +0000 (UTC) Received: (qmail 18565 invoked by uid 500); 1 Dec 2015 15:59:27 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 18534 invoked by uid 500); 1 Dec 2015 15:59:27 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 18511 invoked by uid 99); 1 Dec 2015 15:59:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2015 15:59:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 166E62915E5; Tue, 1 Dec 2015 15:59:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7593146724268961604==" MIME-Version: 1.0 Subject: Re: Review Request 40763: AMBARI-14094 : Remove raise condition in Ranger KMS start if repo creation fails From: "Sebastian Toader" To: "Mahadev Konar" , "Sumit Mohanty" , "Selvamohan Neethiraj" , "Sebastian Toader" , "Alejandro Fernandez" , "Jaimin Jetly" , "Velmurugan Periasamy" Cc: "Gautam Borad" , "Ambari" Date: Tue, 01 Dec 2015 15:59:27 -0000 Message-ID: <20151201155927.1719.208@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Sebastian Toader" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40763/ X-Sender: "Sebastian Toader" References: <20151201121624.1719.52079@reviews.apache.org> In-Reply-To: <20151201121624.1719.52079@reviews.apache.org> Reply-To: "Sebastian Toader" X-ReviewRequest-Repository: ambari --===============7593146724268961604== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40763/#review108514 ----------------------------------------------------------- ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 281) Add a delay otherwise the 5 tries might be exhausted too quickly thus not giiving enough time for RangerAdmin to become operational. - Sebastian Toader On Dec. 1, 2015, 1:16 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40763/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2015, 1:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy. > > > Bugs: AMBARI-14094 > https://issues.apache.org/jira/browse/AMBARI-14094 > > > Repository: ambari > > > Description > ------- > > Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78 > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1 > > Diff: https://reviews.apache.org/r/40763/diff/ > > > Testing > ------- > > Tested for Start all case and checked for Ranger HA and KMS service start together. > > ---------------------------------------------------------------------- > Ran 271 tests in 8.044s > > OK > ---------------------------------------------------------------------- > Total run:878 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > > --===============7593146724268961604==--