ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <>
Subject Re: Review Request 41774: BE: Install packages call takes more than 3 minutes on 900 node cluster
Date Wed, 30 Dec 2015 10:41:38 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 30, 2015, 12:41 p.m.)

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya,
Nate Cole, and Yusaku Sako.


Now should be the correct patch

Bugs: AMBARI-14520

Repository: ambari


On 900 host cluster the call to install packages took like 3 minutes 20 seconds which is kind
of long.
POST http://perf-a-1:8080/api/v1/clusters/c1/stack_versions


Diffs (updated)

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ 3358e8c

  ambari-server/src/main/java/org/apache/ambari/server/state/host/ c56d7ce 



mvn clean test

Current request execution time: 0m22.678s

With current patch, most time (about 40%) is consumed by findConfigurationTagsWithOverrides(cluster,
hostname), but it seems to be inevitable even with batching addExecutionCommandsToStage()
calls into a single invocation. I've tried inserting logging statements to verify that number
of invocations equals to number of hosts.
Rest of time is mostly consumed by org.apache.ambari.server.actionmanager.Stage.addHostRoleExecutionCommand()
(20% of time) and by N invocations of ClustersImpl.getHostsForCluster() (19% of time). The
latter calls can not be cached in method, so I can only rewrite method signature AmbariActionExecutionHelper.addExecutionCommandsToStage(ActionExecutionContext,
Stage) and cache it in ClusterStackVersionResourceProvider. Seems to be a bad deal considering
1-3 seconds (on large clusters ) of performance boost for a rare call vs readability/maintainability
of code.


Dmitro Lisnichenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message