ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt" <mithm...@gmail.com>
Subject Re: Review Request 41784: NN HA wizard should update hawq_dfs_url with nameservice when ha is enabled by ambari
Date Tue, 29 Dec 2015 22:49:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41784/#review112242
-----------------------------------------------------------



ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js (line
37)
<https://reviews.apache.org/r/41784/#comment172598>

    Have you added a corresponding title in messages.js for this step in the rollback controller?


- Matt


On Dec. 29, 2015, 2:40 p.m., Newton Alex wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41784/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 2:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-14225
>     https://issues.apache.org/jira/browse/AMBARI-14225
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There were some minor changes to the patch to make it work for branch-2.2 as compared
to trunk. Hence re-creating a new review request.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/rollback_controller.js
e86b52e 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js
3cb7be7 
>   ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js
580977a 
>   ambari-web/app/data/HDP2/ha_properties.js 627018a 
>   ambari-web/app/messages.js f52b325 
> 
> Diff: https://reviews.apache.org/r/41784/diff/
> 
> 
> Testing
> -------
> 
> Yes, unit tests passed. 
> Manually tested the feature.
> 
> 
> Thanks,
> 
> Newton Alex
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message