ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 41402: Robust Handling of Ambari properites and DB state.
Date Wed, 16 Dec 2015 18:24:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41402/#review110711
-----------------------------------------------------------


Very useful!


ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
(line 170)
<https://reviews.apache.org/r/41402/#comment170748>

    Please add some javadoc for this method.



ambari-server/src/main/python/ambari_server/serverConfiguration.py (line 1315)
<https://reviews.apache.org/r/41402/#comment170745>

    Shouldn't this check of property is in properties dictionary first?
    Right now it is checking if the value is None or 0



ambari-server/src/main/python/ambari_server_main.py (line 243)
<https://reviews.apache.org/r/41402/#comment170747>

    Typo, should be "Required" and "missing_properties"


- Alejandro Fernandez


On Dec. 16, 2015, 11:01 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41402/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 11:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14385
>     https://issues.apache.org/jira/browse/AMBARI-14385
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Robust Handling of Ambari properites and DB state.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java c6f90c0

>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
c4a4e4c 
>   ambari-server/src/main/python/ambari-server.py 41fdfb6 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 223c608 
>   ambari-server/src/main/python/ambari_server_main.py e9bdec3 
> 
> Diff: https://reviews.apache.org/r/41402/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message