ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 41399: If a bunch of RMF resources is defined using list of names, list is modified in runtime
Date Tue, 15 Dec 2015 14:25:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41399/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14373
    https://issues.apache.org/jira/browse/AMBARI-14373


Repository: ambari


Description
-------

Given code like

    
    
    
      base_dirs = [params.kafka_log_dir, params.kafka_pid_dir, params.conf_dir]
      Directory(base_dirs,
                mode=0755,
                cd_access='a',
                owner=params.kafka_user,
                group=params.user_group,
                recursive=True
                )
      set_dir_ownership(base_dirs)
    

base_dirs becomes empty after using it in Directory definition (there is a
side effect here)


Diffs
-----

  ambari-common/src/main/python/resource_management/core/base.py 1711c22 
  ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/kafka.py
f02be4b 

Diff: https://reviews.apache.org/r/41399/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message