ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt" <mithm...@gmail.com>
Subject Review Request 41227: Config properties does not appear in right order
Date Thu, 10 Dec 2015 22:29:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41227/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk, Alexander Denissov, Alejandro Fernandez, bhuvnesh
chaudhary, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.


Bugs: AMBARI-14315
    https://issues.apache.org/jira/browse/AMBARI-14315


Repository: ambari


Description
-------

Any property with index 0 in site_properties.js ends up at the bottom of the config section.
Property with index 0 should ideally be at the top.

Reason why this happens:
https://github.com/apache/ambari/blob/trunk/ambari-web/app/mappers/configs/stack_config_properties_mapper.js#L172

config.index = uiConfigProperty.index || Infinity;
When uiConfigProperty.index = 0, config.index = Infinity


Diffs
-----

  ambari-web/app/mappers/configs/stack_config_properties_mapper.js 3cc08a4 

Diff: https://reviews.apache.org/r/41227/diff/


Testing
-------

Manually tested. 
Parameter with index 0 appears above parameter with index 1.


Thanks,

Matt


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message