ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jun aoki" <jun.aoki....@gmail.com>
Subject Re: Review Request 41221: Save on Repositories dialog box not working
Date Thu, 10 Dec 2015 22:03:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41221/#review109868
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
(line 272)
<https://reviews.apache.org/r/41221/#comment169526>

    Nate, thank you for picking this up!
    It looks like line 272 clusterVersionEntities declaration is no longer needed?


- jun aoki


On Dec. 10, 2015, 9:34 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41221/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 9:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14259
>     https://issues.apache.org/jira/browse/AMBARI-14259
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Prior to this patch, exceptions are thrown if there is any association of the repo to
a cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
3782a9f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
c99f631 
> 
> Diff: https://reviews.apache.org/r/41221/diff/
> 
> 
> Testing
> -------
> 
> Manual testing to confirm change and show the base URL was being updated in the agent
.repo files.
> 
> Automated:
> 
> Tests run: 3621, Failures: 0, Errors: 0, Skipped: 28
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 33:11.296s
> [INFO] Finished at: Thu Dec 10 16:32:33 EST 2015
> [INFO] Final Memory: 31M/753M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message