ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Szabo" <osz...@hortonworks.com>
Subject Re: Review Request 41150: Storm configuration wrong
Date Thu, 10 Dec 2015 10:55:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/#review109734
-----------------------------------------------------------

Ship it!


Ship It!

- Oliver Szabo


On Dec. 9, 2015, 9:33 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41150/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 9:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14302
>     https://issues.apache.org/jira/browse/AMBARI-14302
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle
properties that were already in correct format. It has been changed to recognize if the input
property value is already in the correct format in order to not distort.
> 
> In cases where a cluster is created with a Blueprint that was previously exported the
storm yaml properties are already in correct format thus no need to add surrounding [] to
the property value.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
b3e99b1 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
b4b50cf 
> 
> Diff: https://reviews.apache.org/r/41150/diff/
> 
> 
> Testing
> -------
> 
> Unit tests in progress....
> 
> Manual testing in progress...
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message