ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 41109: AMBARI-14278 : On a cluster with both AMS and Storm, stack advisor throws error in validateStormConfigurations after upgrade if the metrics.reporter.register property is not present
Date Wed, 09 Dec 2015 19:43:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41109/#review109592
-----------------------------------------------------------

Ship it!


Need a green light on manual test results.

- Sid Wagle


On Dec. 9, 2015, 7:41 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41109/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 7:41 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14278
>     https://issues.apache.org/jira/browse/AMBARI-14278
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The Storm Metrics reporter property (metrics.reporter.register) is a known config item
that needs to be added manually when upgraded from Ambari versions before 2.0.0 to any version
with AMS. If that is not done, there is a stack advisor exception that is caused.
> 
> FIX
> Added a check for the presence of the property. If the property is present, we add it
to validation items. Else, we dont add to validation item
> 
> Steps to work around the issue
> 1. Add the following property to storm-site.xml from Ambari Web
> metrics.reporter.register = org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsReporter
> 2. Restart Storm service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
f80f7b9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 946deed

>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
d83f0a8 
> 
> Diff: https://reviews.apache.org/r/41109/diff/
> 
> 
> Testing
> -------
> 
> ambari-server python unit tests pass.
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message