ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 41053: Enforce granular role-based access control for host functions
Date Tue, 08 Dec 2015 20:05:09 GMT


> On Dec. 8, 2015, 1:52 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
lines 742-744
> > <https://reviews.apache.org/r/41053/diff/2/?file=1155383#file1155383line742>
> >
> >     Is this the right permission here? Seems like this is changing desired host
configs and not toggling maintenance state.

Nice catch.  That was a copy and paste error.  It should probably be SERVICE_MODIFY_CONFIGS...
but maybe we need a HOST_MODIFY_CONFIGS.  I meant to look around to see what this was doing
and I guess I got distracted.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41053/#review109366
-----------------------------------------------------------


On Dec. 7, 2015, 6 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41053/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 6 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, Sumit Mohanty,
Swapan Shridhar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14193
>     https://issues.apache.org/jira/browse/AMBARI-14193
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enforce granular role-based access control for host functions:
> 
>                               | Cluster User | Service Operator | Service Administrator
| Cluster Operator | Cluster Administrator | Administrator
> Turn on/off maintenance mode  |              |                  |                   
   | (+)              | (+)                   | (+)
> Add/Delete hosts              |              |                  |                   
   | (+)              | (+)                   | (+)
> View host details             | (+)          | (+)              | (+)               
   | (+)              | (+)                   | (+)
> 
> Entry points affected:
> - GET api/vi/hosts
> - GET api/vi/hosts/:host_name
> - POST api/vi/hosts/:host_name
> - PUT api/vi/hosts/:host_name
> - DELETE api/vi/hosts/:host_name
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
60b6901 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
39d4040 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
c87c338 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
5272c4c 
>   ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
94f119c 
> 
> Diff: https://reviews.apache.org/r/41053/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message