ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aravindan Vijayan" <avija...@hortonworks.com>
Subject Re: Review Request 41063: AMBARI-14257 : Storm metrics do not work after upgrading Ambari to 2.1.2
Date Tue, 08 Dec 2015 00:11:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41063/
-----------------------------------------------------------

(Updated Dec. 8, 2015, 12:11 a.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-14257
    https://issues.apache.org/jira/browse/AMBARI-14257


Repository: ambari


Description (updated)
-------

Problem
Storm metrics do not work after upgrading from versions < 2.1.1 to 2.1.2. ClassNotFound
exception seen in the logs when storm metrics reporter class is accessed.

Bug
Storm lib directory is usually found in /usr/hdp/current/storm-nimbus/lib. In the code we
try to delete the link from /usr/lib/storm/lib which is not present. Hence, we never update
the symlink in the actual location thus causing a stale symlink.

Fix
Change the symlink deletion logic to look at the correct location. 

Fix a bug in resource_management.system module where the action='delete' for Links must call
the os.path.lexists rather than os.path.exists to return true for broken symlinks


Diffs
-----

  ambari-common/src/main/python/resource_management/core/providers/system.py a3b01f0 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
51998fa 

Diff: https://reviews.apache.org/r/41063/diff/


Testing
-------

Manual testing done.

Python unit tests pass.


Thanks,

Aravindan Vijayan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message