ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Di Li" <d...@ca.ibm.com>
Subject Review Request 41047: AMBARI-11268: Quick links for custom services
Date Mon, 07 Dec 2015 19:05:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41047/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jaimin Jetly.


Bugs: AMBARI-11268
    https://issues.apache.org/jira/browse/AMBARI-11268


Repository: ambari


Description
-------

The existing version of the Ambari (2.0) does not have a declarative way to add "Quick Links"
for the custom services. Currently, to add a "Quick Links" dropdown one has to do add quick
links definitions to the UI code, making it very difficult for custom services to have quick
links.

The proposed changes here introduced a way to allow services to define/inherite/update quick
links via quicklinks.json


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
27609e7 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinition.java
45302ff 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java e35e7ac

  ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 76397fb

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
60b6901 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 55816a3

  ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java c2a2a0c 
  ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java a58cda3 
  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Check.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Port.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Protocol.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/QuickLinks.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/QuickLinksConfiguration.java
PRE-CREATION 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml ae58b5c 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml 515f385 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/metainfo.xml dad6dc1 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml 4d1b305 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/SPARK/metainfo.xml db11d05 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/SPARK/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/metainfo.xml 352341b 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml fee10d3 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 90a31f5 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml ca69195 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml ccf5de3 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 2fb8a9a 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml 2c9680c 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/metainfo.xml 5a21200 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackServiceResourceDefinitionTest.java
65f54d5 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
PRE-CREATION 
  ambari-server/src/test/resources/child_quicklinks_to_inherit.json PRE-CREATION 
  ambari-server/src/test/resources/child_quicklinks_to_merge.json PRE-CREATION 
  ambari-server/src/test/resources/child_quicklinks_to_override.json PRE-CREATION 
  ambari-server/src/test/resources/parent_quicklinks.json PRE-CREATION 
  ambari-web/app/assets/data/configurations/quicklinks.json PRE-CREATION 
  ambari-web/app/assets/data/configurations/quicklinks_services.json PRE-CREATION 
  ambari-web/app/mappers.js 312128b 
  ambari-web/app/mappers/quicklinks_mapper.js PRE-CREATION 
  ambari-web/app/mixins.js 276e777 
  ambari-web/app/mixins/main/service/quicklinks_mapping.js PRE-CREATION 
  ambari-web/app/models.js e1bceec 
  ambari-web/app/models/quicklinks/quick_links_config.js PRE-CREATION 
  ambari-web/app/models/quicklinks/quick_links_link.js PRE-CREATION 
  ambari-web/app/templates/main/service/item.hbs ed989a1 
  ambari-web/app/utils/ajax/ajax.js d1d76f3 
  ambari-web/app/views/common/quick_view_link_view.js 23e63ba 
  ambari-web/test/views/common/quick_link_view_test.js fc6b118 

Diff: https://reviews.apache.org/r/41047/diff/


Testing
-------

unit test
patch Ambari 2.2.0 cluster with server, stack, UI changes and see if the quick links are populated
and can open external sites when clicked.


Thanks,

Di Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message