ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 41041: Add unit test coverage for ConfigMergeHelper#getConflicts
Date Mon, 07 Dec 2015 18:19:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41041/#review109173
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java (lines 86
- 87)
<https://reviews.apache.org/r/41041/#comment168640>

    Empty 1) ?


- Jonathan Hurley


On Dec. 7, 2015, 10:08 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41041/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 10:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, Jayush
Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-14250
>     https://issues.apache.org/jira/browse/AMBARI-14250
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add unit test coverage for ConfigMergeHelper#getConflicts
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java 0610137

>   ambari-server/src/test/java/org/apache/ambari/server/state/ConfigMergeHelperTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41041/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message