ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 40986: Express Upgrades Fail To Stop Services Because Of Destroyed Configurations
Date Fri, 04 Dec 2015 22:02:26 GMT


> On Dec. 4, 2015, 4:51 p.m., Nate Cole wrote:
> > RU has a task that will rollback directories:
> > 
> >       <execute-stage title="Restore configuration directories and remove HDP
2.3 symlinks">
> >         <task xsi:type="execute">
> >           <script>scripts/ru_set_all.py</script>
> >           <function>unlink_all_configs</function>
> >         </task>
> >       </execute-stage>
> > 
> > Do we need anything special in this case when downgrading to HDP-2.1 and 2.2?  (I
doubt it, but just bringing it up)

There's no downgrade to 2.1 because you deleted it.

For downgrade to 2.2, I believe we're OK but I will test this.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40986/#review109034
-----------------------------------------------------------


On Dec. 4, 2015, 3:48 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40986/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 3:48 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-14220
>     https://issues.apache.org/jira/browse/AMBARI-14220
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-13824 introduced a regression caused by additions of code to conf_select which
destroyed configuration directories. Long story short is that conf_select should be told to
create symlinks and move configurations around; it should  not do it on every select() call.
> 
> I removed the offending code and have install_packages determine if symlinking should
be done in conf_select.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
24ca151 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
d299602 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
69709e5 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0170806

>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
3961897 
> 
> Diff: https://reviews.apache.org/r/40986/diff/
> 
> 
> Testing
> -------
> 
> Upgrades from 2.1 to 2.3, 2.2 to 2.3, and 2.3 to 2.3; no side effects yet.
> 
> Working on tests...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message