ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Nagar" <gna...@hortonworks.com>
Subject Re: Review Request 40969: Changes in Instance Definition does not get reflects in pig and hive view due to caching in UserLocal.java
Date Fri, 04 Dec 2015 13:50:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40969/
-----------------------------------------------------------

(Updated Dec. 4, 2015, 1:50 p.m.)


Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Changes
-------

Added null check


Bugs: AMBARI-14212
    https://issues.apache.org/jira/browse/AMBARI-14212


Repository: ambari


Description
-------

Added an onUpdate hook for view class which will be called when configuration parameter changes.
Added default implementationof View class (ViewImpl). It will clear all cached object for
the instance whenever configuration changes.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
7cecedc 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java ddfd4e3 
  ambari-views/src/main/java/org/apache/ambari/view/View.java 4de1746 
  contrib/views/hive/src/main/resources/view.xml 23f901b 
  contrib/views/pig/src/main/java/org/apache/ambari/view/pig/utils/UserLocalObjects.java 1b22a45

  contrib/views/pig/src/main/resources/view.xml 636e26e 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/FileTest.java 7f0db4a 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/HelpTest.java 5e41aed 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/IntegrationalTest.java 9813fea

  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/JobTest.java 71c8828 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTest.java d00b414

  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestHDFSUnmanaged.java
d33fd2f 
  contrib/views/pig/src/test/java/org/apache/ambari/view/pig/test/ScriptTestUnmanaged.java
8322d2c 
  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java 4d36de0 
  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ViewImpl.java PRE-CREATION

  contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ViewUserLocal.java b9d80b1


Diff: https://reviews.apache.org/r/40969/diff/


Testing
-------

Manual testing done


Thanks,

Gaurav Nagar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message