ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 40912: AMBARI-14169 : SYNC SOURCE property needs to be maintained for RU (2.2.x to 2.3.x)
Date Thu, 03 Dec 2015 19:27:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40912/#review108862
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml (line 447)
<https://reviews.apache.org/r/40912/#comment168324>

    Same configs need to be called from nonrolling upgrade in HDP 2.2->2.3.
    
    see file
    ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 82)
<https://reviews.apache.org/r/40912/#comment168325>

    This doesn't make sense. This says,
    if "xasecure.audit.destination.hdfs" is false, then set it to false
    
    Same issue for the property below with a condition that true stays true.
    the construct of
    
    <set key="propname" value="value" /> can be used to forcefully set the value.



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 127)
<https://reviews.apache.org/r/40912/#comment168327>

    ranger-ugsync-site has this property defaulting to false, but here it is being set to
true. Is that correct?



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 132)
<https://reviews.apache.org/r/40912/#comment168328>

    Does this have to be case insensitive?
    Default value for the stack is "UNIX"



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (line 138)
<https://reviews.apache.org/r/40912/#comment168329>

    Does this have to be case insensitive?
    Need to check if the stack allows LDAP


- Alejandro Fernandez


On Dec. 3, 2015, 1:58 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40912/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 1:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty,
Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-14169
>     https://issues.apache.org/jira/browse/AMBARI-14169
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains Ranger changes for RU and EU to migrate properties from 2.2 to 2.3 after
Smart Config changes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml
007f6a4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
98e8e4f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 0f7169c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 54236cf

> 
> Diff: https://reviews.apache.org/r/40912/diff/
> 
> 
> Testing
> -------
> 
> Upgrade Ranger from HDP 2.2 to 2.3 using Ambari-2.1.3 and check migration of properties.
> -----------------------------------------------------------------------
> Ran 271 tests in 8.739s
> 
> OK
> ----------------------------------------------------------------------
> Total run:879
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message