ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 40855: Exported blueprint does not contain "policymgr_external_url" property
Date Wed, 02 Dec 2015 14:28:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40855/#review108641
-----------------------------------------------------------

Ship it!


Patch looks fine, just a minor javadoc issue below.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
(line 132)
<https://reviews.apache.org/r/40855/#comment168098>

    Minor issue:
    
    Adding the Ranger property here is fine, but the Ranger property is a little different
than the properties in this set, which all refer to the HDFS Nameservice logical name. 
    
    Maybe add a comment here to indicate that this set contains other HA properties that will
be exported even if the expected hostname information isn't found.  
    
    I think adding the property here is correct, it might just be a good idea to add some
comments to make this clearer.  
    
    Thanks


- Robert Nettleton


On Dec. 2, 2015, 7:37 a.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40855/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 7:37 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Robert Nettleton.
> 
> 
> Bugs: AMBARI-14148
>     https://issues.apache.org/jira/browse/AMBARI-14148
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case of HA deployment the "policy_external_url" is not automatically constructed from
the host and port of Ranger Admin but rather is the load balancer URL that is on front of
the Ranger Admin instances which is provided by user. 
> 
> This property has been added to the list of properties that can support HA using a nameservice
name otherwise this property is ignored by Blueprint export when it's format differs from
cluster_host:port
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
7f11bb9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py d4d0e83

>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
17c0157 
> 
> Diff: https://reviews.apache.org/r/40855/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:
> 1. Verified export with both cases when Ranger is deployed with UI and using Blueprint
> 
> Unit tests:
> ----------------------------------------------------------------------
> Total run:804
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message