ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 40805: Enforce granular role-based access control for stack version functions
Date Wed, 02 Dec 2015 02:24:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40805/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 9:24 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, Nate
Cole, and Sumit Mohanty.


Changes
-------

Updated due to reviewer comments.


Bugs: AMBARI-14114
    https://issues.apache.org/jira/browse/AMBARI-14114


Repository: ambari


Description
-------

Enforce granular role-based access control for stack version functions:

                           | Cluster User | Service Operator | Service Administrator | Cluster
Operator | Cluster Administrator | Administrator 
---------------------------|--------------|------------------|-----------------------|------------------|-----------------------|---------------
						 
View stack version details | (+)          | (+)              | (+)                   | (+)
             | (+)                   | (+)
Manage stack versions      |              |                  |                       |   
              |                       | (+)
Edit stack repository URLs |              |                  |                       |   
              |                       | (+)

Entry points affected:
- GET /api/v1/stacks/:stack_name/versions/:version_id
- GET /api/v1/stacks/:stack_name/versions/:version_id
- PUT /api/v1/stacks/:stack_name/versions/:version_id
- POST /api/v1/stacks/:stack_name/versions/:version_id
- DELETE /api/v1/stacks/:stack_name/versions/:version_id


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
062b0cb 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
7f88286 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java
4e4386e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
dfaef98 
  ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
634d840 

Diff: https://reviews.apache.org/r/40805/diff/


Testing
-------

manually tested

# Local test resuts:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:46.219s
[INFO] Finished at: Mon Nov 30 18:47:07 EST 2015
[INFO] Final Memory: 66M/923M
[INFO] ------------------------------------------------------------------------

# Jenkins test resuts:


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message