ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Grinenko" <hapy.les...@gmail.com>
Subject Re: Review Request 40810: AMBARI-14121. Express Upgrade authors configs as _anonymous instead of auth user
Date Tue, 01 Dec 2015 06:29:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40810/#review108458
-----------------------------------------------------------



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
(line 1024)
<https://reviews.apache.org/r/40810/#comment167914>

    Should we add some test to check, if the username was set correctly?


- Dmytro Grinenko


On Dec. 1, 2015, 2:48 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40810/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2015, 2:48 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate
Cole, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-14121
>     https://issues.apache.org/jira/browse/AMBARI-14121
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing an Express Upgrade from HDP 2.2 to 2.3, Ambari authors the configs as
"_anonymous" instead of the authenticate user.
> 
> This is because the server side action UpdateDesiredStackAction.java calls upgradeResourceProvider.applyStackAndProcessConfigurations
but doesn't pass it the username.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
748dbbe 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
44b13de 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
93360bd 
> 
> Diff: https://reviews.apache.org/r/40810/diff/
> 
> 
> Testing
> -------
> 
> Waiting for unit test results.
> Ran manually for UpgradeResourceProviderTest.java and it passed.
> 
> Verified during an Express Upgrade from HDP 2.2 to 2.3
> ```
> ambari=> select service_name, version, user_name from serviceconfig;
>  service_name | version | user_name
> --------------+---------+-----------
>  HDFS         |       1 | admin
>  ZOOKEEPER    |       1 | admin
>  MAPREDUCE2   |       1 | admin
>  YARN         |       1 | admin
>  ZOOKEEPER    |       2 | admin
>  MAPREDUCE2   |       2 | admin
>  HDFS         |       2 | admin
>  YARN         |       2 | admin
> ```
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message