Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Date: Fri, 20 Nov 2015 19:12:11 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: dev@ambari.apache.org
Message-ID: <JIRA.12848985.1437768251000.140493.1448046731468@Atlassian.JIRA>
In-Reply-To: <JIRA.12848985.1437768251000@Atlassian.JIRA>
References: <JIRA.12848985.1437768251000@Atlassian.JIRA>
 <JIRA.12848985.1437768251384@arcas>
Subject: [jira] [Commented] (AMBARI-12537) Blueprints Cluster configuration
 task thread should not wait indefinitely
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AMBARI-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018573#comment-15018573 ] 

Hudson commented on AMBARI-12537:
---------------------------------

ABORTED: Integrated in Ambari-trunk-Commit #3877 (See [https://builds.apache.org/job/Ambari-trunk-Commit/3877/])
AMBARI-12537. Blueprints Cluster configuration task thread should not (rnettleton: [http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d8e97b17210a79c82ffe00abd67c0c829027951f])
* ambari-server/src/main/java/org/apache/ambari/server/topology/AsyncCallableService.java
* ambari-server/src/test/java/org/apache/ambari/server/topology/AsyncCallableServiceTest.java
* ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigureClusterTaskTest.java
* ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
* ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java


> Blueprints Cluster configuration task thread should not wait indefinitely
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-12537
>                 URL: https://issues.apache.org/jira/browse/AMBARI-12537
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.1
>            Reporter: Robert Nettleton
>            Assignee: Laszlo Puskas
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: AMBARI-12537.v8.patch
>
>
> There are a few instances of a threading pattern in the Blueprints configuration processor that should be modified slightly to avoid an indefinite wait in the case of an error condition. 
> The TopologyManager.ClusterConfigureTask demonstrates this problem, where a thread will sleep repeatedly, and then loop infinitely if a condition is not reached.  
> In the error scenario, this could potentially keep the thread running indefinitely, which is a waste of resources.  
> The TopologyManager.ClusterConfigureTask, and perhaps other scenarios like this in Blueprints as well, should be modified to include some kind of timeout on these waiting threads.  If the condition is not met within a reasonable amount of time, the thread should log that condition and exit.   Leaving the thread to execute indefinitely for a condition that will never be met is wasting resources, and should be addressed.  
> This configuration timeout may need to be configurable as well, since different cluster sizes will have different timing issues.  


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)