Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F18118C38 for ; Mon, 30 Nov 2015 22:43:18 +0000 (UTC) Received: (qmail 39360 invoked by uid 500); 30 Nov 2015 22:43:18 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 39328 invoked by uid 500); 30 Nov 2015 22:43:18 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 39311 invoked by uid 99); 30 Nov 2015 22:43:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 22:43:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6A1592AD969; Mon, 30 Nov 2015 22:43:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6744742180193977138==" MIME-Version: 1.0 Subject: Re: Review Request 40793: Enforce granular role-based access control for cluster functions From: "Robert Levas" To: "Alejandro Fernandez" , "Myroslav Papirkovskyy" , "Nate Cole" , "Sumit Mohanty" , "Jonathan Hurley" Cc: "Robert Levas" , "Ambari" Date: Mon, 30 Nov 2015 22:43:15 -0000 Message-ID: <20151130224315.28067.87493@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40793/ X-Sender: "Robert Levas" References: <20151130143715.28068.79021@reviews.apache.org> In-Reply-To: <20151130143715.28068.79021@reviews.apache.org> Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============6744742180193977138== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40793/ ----------------------------------------------------------- (Updated Nov. 30, 2015, 5:43 p.m.) Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, and Sumit Mohanty. Bugs: AMBARI-14072 https://issues.apache.org/jira/browse/AMBARI-14072 Repository: ambari Description ------- Enforce granular role-based access control for cluster functions: | Cluster User | Service Operator | Service Administrator | Cluster Operator | Cluster Administrator | Administrator ---------------------------|--------------|------------------|-----------------------|------------------|-----------------------|--------------- View status information |(+) |(+) |(+) |(+) |(+) |(+) View configuration |(+) |(+) |(+) |(+) |(+) |(+) View stack version details |(+) |(+) |(+) |(+) |(+) |(+) Enable/disable Kerberos | | | | |(+) |(+) Upgrade/downgrade stack | | | | |(+) |(+) Create new clusters | | | | | |(+) Rename clusters | | | | | |(+) Entry points affected: * PUT /api/v1/clusters/:cluster_name * POST /api/v1/clusters/:cluster_name # Note: Read-only requests (GET) are not protected so that the front end is not broken. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java 4954a96 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java b446121 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e3e7b8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 84c13b9 ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java 7f88286 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java baa394c ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java ca3ca36 ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 3bf6cad ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java 30be261 ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java e93a479 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 84de604 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 2c6905d ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java 634d840 ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java d4b7d5a ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java bdb5156 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java fa6598c ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java 319b9fe Diff: https://reviews.apache.org/r/40793/diff/ Testing ------- Manually tested # Local test results: [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 58:54.570s [INFO] Finished at: Mon Nov 30 07:53:59 EST 2015 [INFO] Final Memory: 67M/1340M [INFO] ------------------------------------------------------------------------ #Jenkins test results: PENDING Thanks, Robert Levas --===============6744742180193977138==--